Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move googleapis-common-protos to main deps #370

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Aug 8, 2023

Proposed changes

Move googleapis-common-protos to main dependency group. Fixes basic installation failure.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected)
  • Something else (e.g. tests, scripts, example, deployment, infrastructure, ...)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document.
  • I have based my branch, and I am making a pull request against, the main branch.
  • Checks and tests pass locally.

Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in order to unblock cosmpy usage in other components)
Later on we will revisit this.

@jrriehl jrriehl merged commit 19907af into main Aug 8, 2023
32 checks passed
@jrriehl jrriehl deleted the fix/deps-googleapi branch August 8, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants